fix: ensure onConnect is always called #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
on-connect
branch
2 times, most recently
from
39ed50c to
d2ddecc
Compare
metcoder95
reviewed
Jun 14, 2024
|
@metcoder95 ptal |
mcollina
requested changes
Jun 24, 2024
ronag
commented
Jun 24, 2024
ronag
commented
Jun 24, 2024
ronag
commented
Jun 24, 2024
metcoder95
approved these changes
Jun 24, 2024
metcoder95
approved these changes
Jun 25, 2024
ronag
added a commit
to nxtedition/undici
that referenced
this pull request
Jun 25, 2024
* upstream/main: fix: ensure onConnect is always called (nodejs#3327) refactor: simplify request error handling (nodejs#3364)
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status